Support for IPython/Jupyter 4.x #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes based on work by GitHub users deto in PR#144
|
Great! |
|
This is great! These changes are working well for me. |
| if len(s) == 0: | ||
| fullpath = find_connection_file() | ||
| else: | ||
| fullpath = find_connection_file(s.lstrip().rstrip()) |
There was a problem hiding this comment.
I guess it's not necessary to call s.lstrip().rstrip() again as It's already been done in line 153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for IPython/Jupyter 4.x using the jupyter_client modules.
Method of connecting to 4.x kernels is based off @deto work in PR#144.