Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images are scaled down #69

Open
noisyneuron opened this issue Apr 30, 2020 · 8 comments
Open

images are scaled down #69

noisyneuron opened this issue Apr 30, 2020 · 8 comments

Comments

@noisyneuron
Copy link

the header image and images through the text are scaled down -- the current URLs returned from wordpress point to images with resolution 1024x576 px --

<img width="100%" alt="Animation of lines of code and visual output"
src="https://itp.nyu.edu/thesis2020/wp-content/uploads/2020/04/animation5-1024x576.gif"
class="figure-img img-fluid">
@EonYang
Copy link
Collaborator

EonYang commented Apr 30, 2020

Can you please share a link to this page? thanks!

@noisyneuron
Copy link
Author

link to my page again :) https://thesis-archive-2020.netlify.app/students/25

EonYang added a commit that referenced this issue Apr 30, 2020
…gerous. Now use he to pre-decode html entities, then use html-react-parser to parse html tags
@EonYang
Copy link
Collaborator

EonYang commented Apr 30, 2020

I checked the actual image size which is 1024 by 576, which seems correct. It does look like blurry, but I personally think it's because of the format.

A suggestion is to use a jpeg or png if you don't mind.

@EonYang
Copy link
Collaborator

EonYang commented Apr 30, 2020

@oveddan BTW, is it possible to request a higher-res hero image size from the server? 1024 do seem a little bit low-quality.

@noisyneuron
Copy link
Author

yea, the actual image I uploaded was 1920x1080 -- it's resized on the server and the 1024 is returned for some reason

@EonYang
Copy link
Collaborator

EonYang commented Apr 30, 2020

e231951

I pushed a workaround for temporarily and dangerously solving this.

Will remove this hack when the server serves a higher-res img.

@noisyneuron
Copy link
Author

just incase it was missed, this is happening for all images, not just the header.

( and when the server resizes, gifs stop animating :( The image right after the abstract here is a gif - if I remove the _1024x576 suffix from the name, it animates again. )

@EonYang
Copy link
Collaborator

EonYang commented May 1, 2020

just incase it was missed, this is happening for all images, not just the header.

( and when the server resizes, gifs stop animating :( The image right after the abstract here is a gif - if I remove the _1024x576 suffix from the name, it animates again. )

Thank you! I assume the server-side has a good reason downscaling images - better traffic optimization.

However, the gif should be fixed.

Unfortunately the server-side can't respond as fast as we do. I think it will take days to implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants