Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orbi_plot_shot_noise() isotopocule filter #44

Open
brettdavidheiser opened this issue Nov 8, 2023 · 3 comments
Open

orbi_plot_shot_noise() isotopocule filter #44

brettdavidheiser opened this issue Nov 8, 2023 · 3 comments
Milestone

Comments

@brettdavidheiser
Copy link
Collaborator

If you have lot of isotopocules the shot noise plots get very busy, especially when facet_wrap. It might be nice to have a built in filter like as in the fuction call orbi_plot_raw_data(isotopocules = c("13C"), y= ratio). Of course it can be done with a filter call before hand.
flageddata_w_ratios |> orbi_analyze_shot_noise() |> dplyr::filter(isotopocule %in% c("13C", "18O")) |> orbi_plot_shot_noise()

@SabrielxD
Copy link
Collaborator

or it can be done with orbi_filter_isox(), no?

@brettdavidheiser
Copy link
Collaborator Author

Yes you can use the orbi_filter_isox(). It looks like you also have to filter out the data that has been labeled "unused" in the data_type before calling the shot noise function

@sebkopf
Copy link
Contributor

sebkopf commented Nov 9, 2023

I'm in favor of providing an isotopocules parameter since we have that in the other plotting functions it would be consistent (default would be to include all). Could also include a flag whether to show unused data but that's something we could consider for all plotting functions. Default should probably be show_unused = TRUE, yes?

@sebkopf sebkopf added this to the v1.4 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants