Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment target too high: iOS 13 + #1

Open
iWeslie opened this issue Feb 8, 2020 · 3 comments
Open

Deployment target too high: iOS 13 + #1

iWeslie opened this issue Feb 8, 2020 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@iWeslie
Copy link

iWeslie commented Feb 8, 2020

Real nice framework! It solved my issue perfectly
But, the deployment target is too high, I think you may downgrade it to iOS 11 - for the most compatibility.
And there is only stopRaining() method without startRaining

@ishan-chhabra
Copy link
Owner

Glad you liked it. 💃
Sure, will downgrade it to iOS 11.

You can start the rain with rain(in:) method.

@iWeslie
Copy link
Author

iWeslie commented Apr 3, 2020

Maybe there's a bug for calling rain(in:) when I have called this method once, cuz the confetti view is loaded and insert another subLayer is not a good choice I think.
So, add a method for start raining again fixed my issue.

public func startRaining() {
    emitter.birthRate = 2
}

@ishan-chhabra
Copy link
Owner

Yes. You are right. Never a good idea to add another layer.

Let's check if the UIView already has this layer, if it does, let's increase the birthRate to reuse the layer.

I will raise a PR about the same. Thank you! 🤗

@ishan-chhabra ishan-chhabra added good first issue Good for newcomers bug Something isn't working labels Apr 3, 2020
@ishan-chhabra ishan-chhabra self-assigned this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants