Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace emittery with obsidian Event class #409

Open
zkat opened this issue Jul 13, 2024 · 1 comment
Open

Replace emittery with obsidian Event class #409

zkat opened this issue Jul 13, 2024 · 1 comment
Labels
technical improvement Internal changes that don't really affect the usage experience in a significant way

Comments

@zkat
Copy link
Member

zkat commented Jul 13, 2024

I didn't know that existed!
@zkat zkat added the technical improvement Internal changes that don't really affect the usage experience in a significant way label Jul 13, 2024
@cwegrzyn
Copy link
Collaborator

I have no idea what, if any, special obsidian-specific functionality it has, but in case it might, I have been leaning towards that.

The exception is code that needs to be testable. We will have to find a way to mock out the obsidian events class if we want to be able to write tests for code that uses obsidian events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical improvement Internal changes that don't really affect the usage experience in a significant way
Projects
Iron Vault Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zkat @cwegrzyn