Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should some commands work regardless of current actor? #382

Open
cwegrzyn opened this issue Jul 7, 2024 · 3 comments
Open

Should some commands work regardless of current actor? #382

cwegrzyn opened this issue Jul 7, 2024 · 3 comments
Labels
polish General polish that doesn't really change behavior but might make things nicer

Comments

@cwegrzyn
Copy link
Collaborator

cwegrzyn commented Jul 7, 2024

As of #381, the reroll command uses our now-standard actor-threading behavior (it requires an actor
and only applies the change if the current actor matches the last node's actor), but it doesn't
need to work this way. It could apply to ANY move in the final position, regardless of whose
actor node it is in. What's the right behavior here?

@zkat
Copy link
Member

zkat commented Jul 7, 2024

I don't think you should be able to reroll someone else's move tbh.

@cwegrzyn
Copy link
Collaborator Author

cwegrzyn commented Jul 7, 2024

I wonder if the answer (at least for reroll) is to prompt if the last actor block is from a different character than the active character.

@zkat
Copy link
Member

zkat commented Jul 8, 2024

That works!

I mean in general I don’t expect this to happen very often at all but I think that would be a nice check to have

@zkat zkat added the polish General polish that doesn't really change behavior but might make things nicer label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish General polish that doesn't really change behavior but might make things nicer
Projects
Status: Backlog
Development

No branches or pull requests

2 participants