From d1d60a1576d1f171251e01aa2b1c2123c215d930 Mon Sep 17 00:00:00 2001
From: mat-if <97762857+mat-if@users.noreply.github.com>
Date: Tue, 25 Jun 2024 12:54:17 -0700
Subject: [PATCH 1/3] Update remaining artifact github actions to v4 (#5072)

---
 .github/workflows/deploy-npm-ironfish-rust-nodejs.yml | 2 +-
 .github/workflows/publish-binaries.yml                | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/deploy-npm-ironfish-rust-nodejs.yml b/.github/workflows/deploy-npm-ironfish-rust-nodejs.yml
index 652fe6a8ac..9eedb960db 100644
--- a/.github/workflows/deploy-npm-ironfish-rust-nodejs.yml
+++ b/.github/workflows/deploy-npm-ironfish-rust-nodejs.yml
@@ -34,7 +34,7 @@ jobs:
         run: npm install --no-workspaces
 
       - name: Download all artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: ironfish-rust-nodejs/artifacts
 
diff --git a/.github/workflows/publish-binaries.yml b/.github/workflows/publish-binaries.yml
index f59f418c6b..6cd4559df8 100644
--- a/.github/workflows/publish-binaries.yml
+++ b/.github/workflows/publish-binaries.yml
@@ -51,7 +51,7 @@ jobs:
             echo "Runner architecture does not match specified architecture"
             exit 1
           fi
-      
+
       # needed for distutils, which is used by nodegyp, arm64 mac runners have 3.12
       - name: Set up Python
         uses: actions/setup-python@v3
@@ -193,7 +193,7 @@ jobs:
           xcrun notarytool submit "${{ steps.set_paths.outputs.zip }}" --keychain-profile "notarytool-profile" --wait
 
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.set_paths.outputs.name }}
           path: tools/${{ steps.set_paths.outputs.zip }}

From 661d94f995cde462a16696f30ab42739d66e173f Mon Sep 17 00:00:00 2001
From: Hugh Cunningham <57735705+hughy@users.noreply.github.com>
Date: Wed, 3 Jul 2024 09:57:02 -0700
Subject: [PATCH 2/3] stops scanState meter on scan completion (#5108)

when started the Meter class sets an interval to update its underlying arrays.
if the meter is not stopped then this interval will keep running and keep the
meter in the heap and leaks the meter memory.

the WalletScanner creates a new ScanState and a new Meter for each scan. when
the wallet is at the head of the chain this creates a new scan each time a block
is added.

fixes the memory leak by ensuring that the ScanState Meter is stopped when the
scan completes and its interval function is cleared
---
 ironfish/src/wallet/scanner/scanState.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ironfish/src/wallet/scanner/scanState.ts b/ironfish/src/wallet/scanner/scanState.ts
index 2d4864ec84..eda13da0a5 100644
--- a/ironfish/src/wallet/scanner/scanState.ts
+++ b/ironfish/src/wallet/scanner/scanState.ts
@@ -51,6 +51,7 @@ export class ScanState {
   }
 
   signalComplete(): void {
+    this.speed.stop()
     this.runningResolve()
   }
 

From 8e6301a67484074f2cfbecc2687ff9d64ae504c9 Mon Sep 17 00:00:00 2001
From: Hugh Cunningham <hugh@iflabs.network>
Date: Mon, 8 Jul 2024 13:23:49 -0700
Subject: [PATCH 3/3] version bump for v2.4.1

---
 ironfish-cli/package.json | 4 ++--
 ironfish/package.json     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ironfish-cli/package.json b/ironfish-cli/package.json
index 0dd32d2ebb..2eb1b8e7eb 100644
--- a/ironfish-cli/package.json
+++ b/ironfish-cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ironfish",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "CLI for running and interacting with an Iron Fish node",
   "author": "Iron Fish <contact@ironfish.network> (https://ironfish.network)",
   "main": "build/src/index.js",
@@ -59,7 +59,7 @@
   },
   "dependencies": {
     "@ironfish/rust-nodejs": "2.4.0",
-    "@ironfish/sdk": "2.4.0",
+    "@ironfish/sdk": "2.4.1",
     "@oclif/core": "3.27.0",
     "@oclif/plugin-autocomplete": "1.3.10",
     "@oclif/plugin-help": "5.1.12",
diff --git a/ironfish/package.json b/ironfish/package.json
index 093f72d438..ac067139f2 100644
--- a/ironfish/package.json
+++ b/ironfish/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ironfish/sdk",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "SDK for running and interacting with an Iron Fish node",
   "author": "Iron Fish <contact@ironfish.network> (https://ironfish.network)",
   "main": "build/src/index.js",