Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timers #86

Conversation

mauropasse
Copy link
Collaborator

@mauropasse mauropasse commented Feb 28, 2022

Mauro Passerino added 2 commits February 28, 2022 11:08
@mauropasse
Copy link
Collaborator Author

    static bool timer_greater(TimerPtr a, TimerPtr b)
    {
      return a->next_call_time() >= b->next_call_time();
    }

I don't remember why we started using next_call_time instead of the previous time_until_trigger.
Was there a reason for next_call_time?
Something related to this?
// We don't use rclcpp::Time::max() because we want to specify the clock type

@mauropasse mauropasse closed this Feb 28, 2022
@mauropasse
Copy link
Collaborator Author

Closed since not all changes necessary

@mauropasse mauropasse deleted the mauro/master-events-executor branch February 28, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant