Issue in PSO?

[denisbogol]

Hi,

I was just studying the code and came across the following function:

  Particle findLBest(int index) {
    std::vector<Particle> neighbours;
    if (index == 0) {
      neighbours.push_back(particles_.back());
    } else {
      neighbours.push_back(particles_[index - 1]);
    }

    if (index == particles_.size() - 1) {
      neighbours.push_back(particles_.front());
    } else {
      neighbours.push_back(particles_[index + 1]);
    }

    Particle lbest = *(std::max_element(neighbours.begin(), neighbours.begin(), Particle::cmp));

    return lbest;
  }

max_element is calling for range neighbours.begin(), neighbours.begin() which doesn't make sense. Moreover, even if you use the full range, there will only be 2 neighboring particles in it, meaning the current particle itself is ignored when calculating the local best.