fix: --version flag includes release version #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tagged release version should match the contents of version.json, so embed the version.json file and add the release version from it to the output from --version. Fixes #145
1 task
lidel
changed the title
lidel
approved these changes
Jun 20, 2024
lidel
added a commit
to ipfs/someguy
that referenced
this pull request
Jun 21, 2024
Porting fix from ipfs/rainbow#149
lidel
added a commit
to ipfs/someguy
that referenced
this pull request
Jun 21, 2024
Porting fix from ipfs/rainbow#149
lidel
added a commit
to ipfs/someguy
that referenced
this pull request
Jun 24, 2024
Porting fix from ipfs/rainbow#149
lidel
added a commit
to ipfs/someguy
that referenced
this pull request
Jun 24, 2024
Porting fix from ipfs/rainbow#149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tagged release version should match the contents of version.json, so embed the version.json file and add the release version from it to the output from
--version.Output:
> docker run --rm -it 3dc6e920ed8d --version rainbow version v1.3.0 2024-06-18-7d805fd-dirty rainbow version v1.3.0 2024-06-18-7d805fd-dirtyFixes #145