Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-branch does not work for RC2 and higher #43

Open
lidel opened this issue Sep 5, 2024 · 2 comments
Open

prepare-branch does not work for RC2 and higher #43

lidel opened this issue Sep 5, 2024 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Sep 5, 2024

Found while working on RC2 and RC3 of ipfs/kubo#10436

using ./kuboreleaser --skip-check-before release --version v0.30.0-rc2 prepare-branch did not bump CurrentVersionNumber in version.go in release-0.30.0

Same for v0.30.0-rc3, had to manually update CurrentVersionNumber in version.go in release-0.30.0.

Not a big deal, we rarely have more than one RC, but would be good to error and ask user to do the step, otherwise it is easy to miss and ship RC with broken ipfs version

(cc @galargh for visibility, in case @gammazero needs to make more than one RC for future 0.31.x)

@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Sep 5, 2024
@galargh
Copy link
Contributor

galargh commented Sep 11, 2024

We'll fix it as the first thing in October, would that work for you?

@lidel
Copy link
Member Author

lidel commented Sep 11, 2024

Yes, that works. Until them we will be following manual steps we have in kubo/docs/RELEASE_CHECKLIST.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants