Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpcds support #8734

Closed
wants to merge 1 commit into from
Closed

feat: add grpcds support #8734

wants to merge 1 commit into from

Conversation

guseggert
Copy link
Contributor

@guseggert guseggert commented Feb 15, 2022

This adds a gRPC datastore shim to go-ipfs by wiring up go-ds-grpc. The motivation is to allow custom local/remote datastores to be used with go-ipfs without having to recompile the go-ipfs binary, compile modules, or even write the datastore in Go. Unix domain sockets are also supported here.

This would enable easier datastore experimentation and enable a third party ecosystem of datastores that end users could use. Common datastores like go-ds-s3 could release binaries / Docker images so that folks could just use a datastore sidecar with vanilla Kubo instead of having to patch & rebuild Kubo (currently the case w/ go-ds-s3).

Some relevant issues/PRs:

If we can agree that this approach is desirable, then the things I have left to do:

  • Move go-ds-grpc into IPFS org
  • Add more rigorous tests to go-ds-grpc
  • Add docs

As a side note, @coryschwartz has been using this with Lotus and the rados datastore.

@guseggert guseggert mentioned this pull request Feb 16, 2022
@BigLep BigLep added this to the TBD milestone Mar 3, 2022
@BigLep BigLep modified the milestones: TBD, Best Effort Track Mar 23, 2022
@guseggert guseggert mentioned this pull request Nov 15, 2022
@guseggert guseggert force-pushed the grpcds branch 8 times, most recently from c2f84fe to 419cfe4 Compare April 3, 2023 01:47
@guseggert guseggert marked this pull request as ready for review April 5, 2023 20:29
@guseggert
Copy link
Contributor Author

I can't get anyone interested in this, so closing.

@guseggert guseggert closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants