Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error during config when running benchmarks #10495

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: error during config when running benchmarks #10495

merged 2 commits into from
Aug 28, 2024

Conversation

gammazero
Copy link
Contributor

  • Benchmarks were failing with error setting number of bits for ed25519 keys, which are the default now.
  • Update the random data generation package to remove a dependency.

@gammazero
Fix benchmarks and tests
428c75c 
- Benchmarks were failing with error setting number of bits for ed25519 keys, which are the default now.
- Update the random data generation package to remove a dependency.
@gammazero gammazero added the skip/changelog This change does NOT require a changelog entry label Aug 28, 2024
@gammazero gammazero requested a review from a team as a code owner August 28, 2024 01:14
@gammazero gammazero changed the title fix: config error when running benchmarks fix: error during config when running benchmarks Aug 28, 2024
@lidel lidel merged commit 175aabd into master Aug 28, 2024
15 checks passed
@lidel lidel deleted the fix/benchmarks branch August 28, 2024 16:21
lidel pushed a commit that referenced this pull request Aug 28, 2024
@gammazero @lidel
fix: error during config when running benchmarks (#10495)
f0d2c99 
- Benchmarks were failing with error setting number of bits for ed25519 keys, which are the default now.
- Update the random data generation package to remove a dependency.

(cherry picked from commit 175aabd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @lidel