chore: give t0116-gateway-cache.sh exec permissions #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to revisit how Kubo is executing the sharness tests to ensure it fails in these cases. Boxo is very naive and just runs all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharness for
t0116-gateway-cache.shhas been broken since #9999 since the file got its executable permissions removed in that PR. Somehow, that slipped under the cracks in Kubo: we got no error! In Boxo, the execution of the tests is more naive and finally failed withpermission denied. It seems like we haven't been running this tests anywhere for 2 weeks, hence we didn't know.This PR adds back the permissions and restores the necessary fixtures. I will be merging once it passes, but cc @lidel and @laurentsenta for visibility.