From f93a3869849ca1e5e07ae5ae05fb615ae477a1bd Mon Sep 17 00:00:00 2001
From: Jorropo <jorropo.pgm@gmail.com>
Date: Mon, 11 Dec 2023 11:45:08 +0100
Subject: [PATCH] fix: allow daemon to start correctly if the API is null
 (#10062)

(cherry picked from commit 8c4bdd8556e0c8b1a4ea3a6d703402bd6cfe1229)
---
 cmd/ipfs/daemon.go       |  7 +++++--
 test/cli/daemon_test.go  | 25 +++++++++++++++++++++++++
 test/cli/harness/ipfs.go | 17 ++++++++++++++---
 3 files changed, 44 insertions(+), 5 deletions(-)
 create mode 100644 test/cli/daemon_test.go

diff --git a/cmd/ipfs/daemon.go b/cmd/ipfs/daemon.go
index f46dbdd8cb2..4ad9b629ce0 100644
--- a/cmd/ipfs/daemon.go
+++ b/cmd/ipfs/daemon.go
@@ -727,8 +727,11 @@ func serveHTTPApi(req *cmds.Request, cctx *oldcmds.Context) (<-chan error, error
 		return nil, fmt.Errorf("serveHTTPApi: ConstructNode() failed: %s", err)
 	}
 
-	if err := node.Repo.SetAPIAddr(rewriteMaddrToUseLocalhostIfItsAny(listeners[0].Multiaddr())); err != nil {
-		return nil, fmt.Errorf("serveHTTPApi: SetAPIAddr() failed: %w", err)
+	if len(listeners) > 0 {
+		// Only add an api file if the API is running.
+		if err := node.Repo.SetAPIAddr(rewriteMaddrToUseLocalhostIfItsAny(listeners[0].Multiaddr())); err != nil {
+			return nil, fmt.Errorf("serveHTTPApi: SetAPIAddr() failed: %w", err)
+		}
 	}
 
 	errc := make(chan error)
diff --git a/test/cli/daemon_test.go b/test/cli/daemon_test.go
new file mode 100644
index 00000000000..7a8c583a261
--- /dev/null
+++ b/test/cli/daemon_test.go
@@ -0,0 +1,25 @@
+package cli
+
+import (
+	"os/exec"
+	"testing"
+
+	"github.com/ipfs/kubo/test/cli/harness"
+)
+
+func TestDaemon(t *testing.T) {
+	t.Parallel()
+
+	t.Run("daemon starts if api is set to null", func(t *testing.T) {
+		t.Parallel()
+		node := harness.NewT(t).NewNode().Init()
+		node.SetIPFSConfig("Addresses.API", nil)
+		node.Runner.MustRun(harness.RunRequest{
+			Path:    node.IPFSBin,
+			Args:    []string{"daemon"},
+			RunFunc: (*exec.Cmd).Start, // Start without waiting for completion.
+		})
+
+		node.StopDaemon()
+	})
+}
diff --git a/test/cli/harness/ipfs.go b/test/cli/harness/ipfs.go
index dde7e3495fc..8537e2aa25d 100644
--- a/test/cli/harness/ipfs.go
+++ b/test/cli/harness/ipfs.go
@@ -38,9 +38,20 @@ func (n *Node) SetIPFSConfig(key string, val interface{}, flags ...string) {
 	n.IPFS(args...)
 
 	// validate the config was set correctly
-	var newVal string
-	n.GetIPFSConfig(key, &newVal)
-	if val != newVal {
+
+	// Create a new value which is a pointer to the same type as the source.
+	var newVal any
+	if val != nil {
+		// If it is not nil grab the type with reflect.
+		newVal = reflect.New(reflect.TypeOf(val)).Interface()
+	} else {
+		// else just set a pointer to an any.
+		var anything any
+		newVal = &anything
+	}
+	n.GetIPFSConfig(key, newVal)
+	// dereference newVal using reflect to load the resulting value
+	if !reflect.DeepEqual(val, reflect.ValueOf(newVal).Elem().Interface()) {
 		log.Panicf("key '%s' did not retain value '%s' after it was set, got '%s'", key, val, newVal)
 	}
 }