Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Add interface-go-ipfs-core tests using the go-ipfs-http-client #55

Open
Stebalien opened this issue Mar 12, 2019 · 3 comments
Open

Add interface-go-ipfs-core tests using the go-ipfs-http-client #55

Stebalien opened this issue Mar 12, 2019 · 3 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

We should cross-test js-ipfs using the interface-go-ipfs-core test suite and the go-ipfs-http-client. This will currently fail as go-ipfs-http-client uses the streaming API but writing this integration is a good starting point.

@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 12, 2019
@Stebalien
Copy link
Member Author

@magik6k any interest in taking this on?

@magik6k
Copy link
Member

magik6k commented Mar 12, 2019

I'm not sure how we should integrate those 2 test suites. Should this just be 2 separate things, or should JS somehow invoke Go tests?

@Stebalien
Copy link
Member Author

I'm thinking two separate things. JS will spin up a js node and a go node and run it's test. Go will spin up a js node and a go node (using IPTB) and run the go tests (separately).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants