chore: make clean and docker cleanup #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds 'make clean' that removes artifacts - improves ux when working with docker, especially when image is missing - 'make' only builds the binary, kubo logic needs to be explicitly called
lidel
commented
Jul 14, 2023
Makefile
Outdated
| find ./fixtures -name '*.car' -exec ipfs dag import {} \; | ||
| find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; | ||
| find ./fixtures -name '*.car' -exec ipfs dag import --stats --pin-roots=false {} \; | ||
| find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --offline --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; |
There was a problem hiding this comment.
💭 iiuc this makes put finish instantly, and not block on putting each record to 20 peers
Makefile
Outdated
| @@ -15,8 +22,8 @@ provision-cargateway: ./fixtures.car | |||
| car -c ./fixtures.car & | |||
|
|
|||
| provision-kubo: | |||
| find ./fixtures -name '*.car' -exec ipfs dag import {} \; | |||
| find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; | |||
| find ./fixtures -name '*.car' -exec ipfs dag import --stats --pin-roots=false {} \; | |||
There was a problem hiding this comment.
ℹ️ pinning blocks on things like missing blocks (#85) – we don't need to pin, as GC is not enabled by default in Kubo
laurentsenta
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I made locally to make local dev easier: