-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS test sends non-CORS request #217
Comments
I would say also, the GET test expects the following headers to be present in the response:
Of these only Is it just asserting on the behaviour of the go-HTTP server? There's no mention of CORS in any of the HTTP Gateway specs so it's unclear what's intended to happen here. |
Skips practically all of them to just get the framework in place. I'm not sure all the tests are valid, the spec is missing large chunks of functionality asserted in the tests, but the assertions don't necessarily assert IETF/W3c spec compliant behaviour, for example: ipfs/gateway-conformance#217
Skips practically all of them to just get the framework in place. I'm not sure all the tests are valid, the spec is missing large chunks of functionality asserted in the tests, but the assertions don't necessarily assert IETF/W3c spec compliant behaviour, for example: ipfs/gateway-conformance#217
There's a test:
It makes a GET request to
"/ipfs/{{CID}}/"
and expectsAccess-Control-Allow-Origin
etc in the response.The test sends:
The fetch spec says:
There is no
Origin
header in the request, so this is not a CORS request.Why does the test expect CORS headers in the response?
The text was updated successfully, but these errors were encountered: