Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bitswap/session): cleanup live wants on cancel #690

Merged
merged 4 commits into from
Oct 18, 2024
Merged

fix(bitswap/session): cleanup live wants on cancel #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e02fa0
fix(bitswap/session): cleanup live wants on cancel
Wondertan Oct 14, 2024
d20c747
Merge branch 'main' into cleanup-live-wants
gammazero Oct 18, 2024
da0654d
Update changelog
gammazero Oct 18, 2024
cb59df1
chore: CHANGELOG.md
lidel Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ The following emojis are used to highlight certain changes:
### Fixed

- `routing/http/client`: optional address and protocol filter parameters from [IPIP-484](https://github.com/ipfs/specs/pull/484) use human-readable `,` instead of `%2C`. [#688](https://github.com/ipfs/boxo/pull/688)
- `bitswap/client` Cleanup live wants when wants are canceled. This prevents live wants from continuing to get rebroadcasted even after the wants are canceled. [#690](https://github.com/ipfs/boxo/pull/690)

### Security

Expand Down
1 change: 1 addition & 0 deletions bitswap/client/internal/session/sessionwants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func (sw *sessionWants) PrepareBroadcast() []cid.Cid {
func (sw *sessionWants) CancelPending(keys []cid.Cid) {
for _, k := range keys {
sw.toFetch.Remove(k)
delete(sw.liveWants, k)
gammazero marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down