Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gw): IPIP-402 CARs return useful blocks on not found errors #440

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

aschmahmann
Copy link
Contributor

Fix extracted from #369 that could be suitable for a patch release.

@aschmahmann aschmahmann requested review from lidel, hacdias and a team as code owners August 17, 2023 16:20
@aschmahmann aschmahmann force-pushed the fix/gateway-ipip-402-car-return-err-blocks branch from 59cac29 to 7edb8a4 Compare August 17, 2023 16:27
@aschmahmann aschmahmann force-pushed the fix/gateway-ipip-402-car-return-err-blocks branch from 7edb8a4 to eb36550 Compare August 17, 2023 16:33
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #440 (fece70a) into main (7ec68c5) will decrease coverage by 0.65%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   50.15%   49.50%   -0.65%     
==========================================
  Files         249      246       -3     
  Lines       29990    29946      -44     
==========================================
- Hits        15041    14825     -216     
- Misses      13514    13688     +174     
+ Partials     1435     1433       -2     
Files Changed Coverage Δ
gateway/blocks_backend.go 43.73% <0.00%> (-2.28%) ⬇️
gateway/errors.go 86.84% <ø> (-0.12%) ⬇️

... and 16 files with indirect coverage changes

@lidel lidel changed the title Fix/gateway ipip 402 car return err blocks fix(gw): IPIP-402 CARs return useful blocks on not found errors Aug 17, 2023
lidel added a commit to ipfs/kubo that referenced this pull request Aug 17, 2023
lidel added a commit to ipfs/kubo that referenced this pull request Aug 17, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in ipfs/kubo#10084 and looks green 👍

.github/workflows/gateway-conformance.yml Outdated Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (squash) August 18, 2023 06:19
@hacdias hacdias disabled auto-merge August 18, 2023 06:27
@hacdias hacdias merged commit 654231b into main Aug 18, 2023
13 of 14 checks passed
@hacdias hacdias deleted the fix/gateway-ipip-402-car-return-err-blocks branch August 18, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants