This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
set window title to first h1 or h2 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set window title to first h1 or h2. This does not affect the hard-coded head title that appears in the top bar of the app, and therefore does not affect metadata that is sucked into social network postings. It probably also does not affect search/SEO.
|
this was my first commit and pull request to anything, ever. hope i did it right... |
|
result should be something like this: |
|
Hey, thanks so much, @jbshirk! This looks pretty good. You're right, this wouldn't affect SEO or social network metadata, as it is done afterwards. And this is a good first PR - sorry we've taken so long to get back to you. I'm going to wait for someone else to check this out before merging it, as I'm not sure it is needed for this example at the moment. |
|
Related to #36 |
|
LGTM, thanks 👍 |
ghost
merged commit 
ghost
removed
the
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set window title to first h1 or h2. This does not affect the hard-coded
head title that appears in the top bar of the app, and therefore does
not affect metadata that is sucked into social network postings. It
probably also does not affect search/SEO.