Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovsp4rt] PrepareVlanPopTableEntry truncates vlan_id #684

Open
ffoulkes opened this issue Sep 1, 2024 · 0 comments
Open

[ovsp4rt] PrepareVlanPopTableEntry truncates vlan_id #684

ffoulkes opened this issue Sep 1, 2024 · 0 comments

Comments

@ffoulkes
Copy link
Contributor

ffoulkes commented Sep 1, 2024

The PrepareVlanPopTableEntry function encodes the vlan_id action param as a single byte.

The canonical width of a VLAN identifier is bit<12>.

The output field (mod_blob_ptr) is bit<24>.

Note

The unit test should expect, and test with, a 12-bit value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ffoulkes