New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovsp4rt] PrepareFdbTxVlanTableEntry truncates src_port to 8 bits #619

Open

ffoulkes opened this issue Aug 10, 2024 · 0 comments

Labels

bug

Contributor

ffoulkes commented Aug 10, 2024 •

edited

Loading

The PrepareFdbTxVlanTableEntry function encodes the src_port input as a single byte.

The input value (src_port in the mac_learning_port_info struct) is uint32_t.
The parameter value (port_id in the remove_vlan_and_fwd action) is bit<32>.

This appears to be an error.

If it's not a bug, the code should contain a comment acknowledging the truncation and explaining why this is not an error.
If it is a bug, it should be fixed. The unit test should be updated.

Question:

What is the nominal maximum value of a source port? Is is really 32 bits? This should be documented in the code and/or a supporting document. Note that this question needs to be answered for dpdk as well as es2k.

The text was updated successfully, but these errors were encountered:

ffoulkes added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment