Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Linux Networking P4 program name #152

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update Linux Networking P4 program name #152

merged 1 commit into from
Jul 2, 2024

Conversation

5abeel
Copy link
Collaborator

@5abeel 5abeel commented Jul 2, 2024

Update LNW name change after P4 program has been updated to remove the -v3 from name

@5abeel 5abeel changed the title Update LNW name Update Linux Networking P4 program name Jul 2, 2024
ffoulkes
ffoulkes approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shame on them. This is a breaking change. There's nothing wrong with the script having a version number!

@ffoulkes ffoulkes merged commit 8c4b89c into main Jul 2, 2024
4 checks passed
@ffoulkes ffoulkes deleted the lnw-p4-name-change branch July 2, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoulkes ffoulkes ffoulkes approved these changes

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5abeel @ffoulkes