-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use yarn, fix comments #1953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the READMEs pls? I think they may reference npm
thibault-martinez
previously approved these changes
Feb 6, 2024
Alex6323
reviewed
Feb 6, 2024
sdk/src/wallet/account/operations/transaction/high_level/minting/create_native_token.rs
Outdated
Show resolved
Hide resolved
Alex6323
reviewed
Feb 6, 2024
thibault-martinez
approved these changes
Feb 6, 2024
Alex6323
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Only use yarn so we don't have multiple lock files. Changed the examples installation to use
yarn link
, because otherwise it always failed withAlso updated wrong comments.
Links to any relevant issues
Closes #1949
Closes #1925
Type of change
How the change has been tested
Running installation commands and an example afterwards