Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use yarn, fix comments #1953

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Only use yarn so we don't have multiple lock files. Changed the examples installation to use yarn link, because otherwise it always failed with

error: current package believes it's in a workspace when it's not:
current:   /iota-sdk/bindings/nodejs/examples/node_modules/@iota/sdk/Cargo.toml
workspace: /iota-sdk/Cargo.toml

Also updated wrong comments.

Links to any relevant issues

Closes #1949
Closes #1925

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Documentation Fix

How the change has been tested

Running installation commands and an example afterwards

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the READMEs pls? I think they may reference npm

@thibault-martinez thibault-martinez merged commit cd3345a into iotaledger:develop Feb 6, 2024
36 of 38 checks passed
@Thoralf-M Thoralf-M deleted the yarn-only branch February 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use only yarn in bindings Fix send_nft() doc comments
3 participants