Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle potential problems from submitting blocks #2111

Closed
Thoralf-M opened this issue Mar 1, 2024 · 1 comment · Fixed by #2120
Closed

Handle potential problems from submitting blocks #2111

Thoralf-M opened this issue Mar 1, 2024 · 1 comment · Fixed by #2120
Assignees
Labels
m-wallet Module - Wallet

Comments

@Thoralf-M
Copy link
Member

Handle potential problems from submitting the signed transaction in a block

// Ignore errors from sending, we will try to send it again during [`sync_pending_transactions`]
let block_id = match self
.submit_signed_transaction(
signed_transaction_data.payload.clone(),
options.as_ref().and_then(|options| options.issuer_id),
)
.await
{
Ok(block_id) => Some(block_id),
Err(err) => {
log::error!("Failed to submit_transaction_payload {}", err);
None
}
};

In stardust we just reissued the transaction payload in new blocks, but with Mana and commitmentcontextinputs this isn't working fine anymore.
A block could potentially be submitted, but an error returned. A block could be submitted, but failed.
We should probably try to submit the block multiple times depending on the error we get and if it fails make sure to also set the transaction state correct and unlock its inputs

@Thoralf-M Thoralf-M added the m-wallet Module - Wallet label Mar 1, 2024
@Thoralf-M Thoralf-M added this to the v2.0.0 (Q1 2024) milestone Mar 1, 2024
@thibault-martinez thibault-martinez linked a pull request Mar 4, 2024 that will close this issue
@thibault-martinez
Copy link
Member

Closed by #2120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-wallet Module - Wallet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants