oddily ncCF datasets cannot be quoted #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something to push upstream to ERDDAP proper? |
Not sure but in version <2.23 we could pass unquoted URLs, no problem. Now, for >=2.23, we need to quote sometimes, kind of odd but I'm not an expert on URLs standards. I do recall Bob warning me that we should always quote. However, that breaks a few corner cases, so far the search URLs and the ncCF. Hopefully that is it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to wonder if we do need to quote all URLs. The behavior doesn't seem to be consistent as Bob told me. Maybe we should revert all this and quote only the rare cases where
"is present. Anyway, let's give this one last go.