Add pass/login functionality #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
commented
Feb 27, 2024
| @@ -42,7 +42,23 @@ def _sort_url(url): | |||
| def _urlopen(url: str, auth: tuple | None = None, **kwargs: dict) -> BinaryIO: | |||
| if "timeout" not in kwargs.keys(): | |||
| kwargs["timeout"] = 60 | |||
| response = httpx.get(url, follow_redirects=True, auth=auth, **kwargs) | |||
| user = kwargs.pop("user", None) | |||
There was a problem hiding this comment.
@abkfenris I have no idea how/where to test this. I never encountered a password protected ERDDAP server. Do you have any tips for me here to move this PR forward?
PS: Everything may change soon if we get a GSoC candidate to work on ioos/gsoc#44
There was a problem hiding this comment.
No, I haven't played with a passworded ERDDAP either, and it's been long enough that the research that I've done has been garbage collected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #303.