Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Api | Add num_prebooked_rides attribute to TaskList model #409

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Operator Api | Add num_prebooked_rides attribute to TaskList model #409

merged 1 commit into from
Jul 17, 2024

Conversation

tom-ioki
Copy link
Contributor

No description provided.

@tom-ioki tom-ioki self-assigned this Jul 16, 2024
phylor
phylor approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@phylor phylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is only valid for the overview endpoint. We're reusing a model here for two different purposes. I think it's fine for now, maybe we need to be vigilant about it in the future.

@tom-ioki
Copy link
Contributor Author

It seems this is only valid for the overview endpoint. We're reusing a model here for two different purposes. I think it's fine for now, maybe we need to be vigilant about it in the future.

Indeed!

@tom-ioki tom-ioki merged commit 65c9991 into main Jul 17, 2024
2 checks passed
@tom-ioki tom-ioki deleted the amount-prebooked-rides-per-task-list branch July 17, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phylor phylor phylor approved these changes

Assignees

@tom-ioki tom-ioki

Labels
PR: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-ioki @phylor