Adding basic vmlinux identification & extraction #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4mp3t
reviewed
Sep 19, 2023
| } | ||
|
|
||
| impl Opts { | ||
| /// Print the locations of known files (binary, libc, linker) | ||
| pub fn print(&self) { | ||
| println!("Found following {}-land challenge binaries:", if self.ker { "kernel" } else {"user"}); |
There was a problem hiding this comment.
Pretty long line. And double spaces on line 124. Consider running rustfmt on changed files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds kernel-pwning support. Partly fixes #293
Right now it works if shell commands
vmlinux-to-elf [file] [outfile]andextract-vmlinux [file] > [outfile]works.We need to discuss how to add the vmlinux-to-elf and extract-vmlinux dependencies since they both are non-rust, so can't just append into
cargo.toml.vmlinux-to-elfis a github repositoryWe can make it 2 ways:
README.mdhow to install them both.What do you prefer?