Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change lib to esnext module, upgrade to polkadot/api 10.9.1 #672

Merged
merged 43 commits into from
Aug 24, 2023
Merged

Chore: Change lib to esnext module, upgrade to polkadot/api 10.9.1 #672

merged 43 commits into from
Aug 24, 2023

Conversation

bvotteler
Copy link
Contributor

@bvotteler bvotteler commented Aug 15, 2023

Resolves #670

Update polkadot/api to latest (10.9.1) so it works with our newest runtime 1.25.0.
Had to change module from previously 'CommonJs' to 'esnext' due to a blocking issue with polkadot typegen ( polkadot-js/api#5540 ) which only has a workaround for esnext modules.

TODO before ready for review:

  • migrate unit tests from mocha -> jest
  • migrate integration tests from mocha -> jest
  • unit tests run and pass
  • integration tests run and pass
  • check if we want to consider another workaround and add manual definitions for those that cannot be generated until upgraded (did that and provided lib version 2.4.3)
  • revert manual definition for transactionPaymentApi.queryInfo (Runtime call is not available in your environment #673)

@bvotteler bvotteler marked this pull request as ready for review August 23, 2023 08:11
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job handling the migration to jest 👏

src/utils/bitcoin-core-client.ts Outdated Show resolved Hide resolved
@bvotteler bvotteler merged commit 89374d4 into interlay:master Aug 24, 2023
2 checks passed
@bvotteler bvotteler deleted the chore-upgrade-polkadot-js branch August 24, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Upgrade polkadot-js api
2 participants