Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

Adding dynamic mode doc and updating ashell doc #1876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brianjjones
Copy link
Contributor

Signed-off-by: Brian J Jones [email protected]

Copy link
Contributor

@grgustaf grgustaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Travis whitespace error.

Otherwise LGTM apart from doc title stuff...

docs/dynamic.md Outdated
@@ -0,0 +1,34 @@
Dynamic mode - Adds the ability to run JS from the filesystem
============================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match the equals signs to the text above.

Also, I suggest removing "Adds the ability to" -- titles should be more succinct.

Signed-off-by: Brian J Jones <[email protected]>
@brianjjones
Copy link
Contributor Author

Updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants