Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint prettier plugin and husky #66

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

NingW101
Copy link
Contributor

@NingW101 NingW101 commented Oct 9, 2024

@gyagp Eslint rules for prettier and husky added. PTAL

@gyagp
Copy link
Contributor

gyagp commented Oct 9, 2024

Thanks for doing this! Overall it's great, but I hope to lint on staged files only. Here is a related post: https://medium.com/@bkn020612/using-eslint-husky-lint-staged-6d6609b02fc2

Copy link
Contributor

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we may lint on staged files only

@NingW101
Copy link
Contributor Author

LGTM if we may lint on staged files only

Updated, thanks for the great advice, now we only lint on staged files

@NingW101
Copy link
Contributor Author

@ibelem PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants