Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

reconsider how many binaries we build #846

Open
pohly opened this issue Jan 11, 2021 · 0 comments
Open

reconsider how many binaries we build #846

pohly opened this issue Jan 11, 2021 · 0 comments
Labels
future needs to be fixed in some future release

Comments

@pohly
Copy link
Contributor

pohly commented Jan 11, 2021

Originally, PMEM-CSI images contained a single pmem-csi-driver binary which served two different purposes (node and controller part). Later, pmem-csi-operator was added.

Building one Go binary per image makes the image smaller because the Go runtime only needs to be included once. Therefore it might make sense to merge the operator functionality into the pmem-csi-driver binary, potentially in combination with renaming it to pmem-csi.

On the other hand, command line options become more confusing when they only apply in some modes. One way to address that is by having a command line syntax of pmem-csi <common options> <operation> <per operation options> (as in other tools which also combine multiple different operations in the same binary).

@pohly pohly added the future needs to be fixed in some future release label Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
future needs to be fixed in some future release
Projects
None yet
Development

No branches or pull requests

1 participant