Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX build fails #276

Closed
rhpvorderman opened this issue Jan 31, 2024 · 7 comments
Closed

ARM OSX build fails #276

rhpvorderman opened this issue Jan 31, 2024 · 7 comments

Comments

@rhpvorderman
Copy link
Contributor

I ran into this. I found: #226 is supposed to fix this.

  CPPAS    crc/aarch64/crc16_t10dif_pmull.lo
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/crc16_t10dif_pmull-8d2f3f.s:208:9: error: unknown AArch64 fixup kind!
        ldr q_fold_const, fold_constant
        ^

Just making this issue in order to track the problem. I have very little skin in the game. Currently osx-arm64 are advised to use rosetta when using bioinformatics pacakges, so it is not a problem that the dependency is not natively compiled.

When it does natively compile again, I will make sure the conda-forge channel puts out a binary distribution.

@cielavenir
Copy link
Contributor

master HEAD builds now, though it might segfault (due to using x18), avoiding in under review

@cielavenir
Copy link
Contributor

@rhpvorderman This is now fully fixed.

@rhpvorderman
Copy link
Contributor Author

Great. Looking forward to the next ISA-L release. Thanks for all that work @cielavenir !

@cielavenir
Copy link
Contributor

oh @rhpvorderman please test if isa-l HEAD works as expected....

@cielavenir
Copy link
Contributor

well, passed. https://github.com/cielavenir/python-isal-py2/actions/runs/8464068215

@rhpvorderman
Copy link
Contributor Author

Thanks!

@corneliusroemer
Copy link

Very cool! Looking forward to release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants