Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance llvm-build behavior #250

Open
WangJialei-A opened this issue Aug 15, 2024 · 3 comments
Open

Enhance llvm-build behavior #250

WangJialei-A opened this issue Aug 15, 2024 · 3 comments
Assignees
Labels
ci Continuous integration and automation enhancement New feature or request
Milestone

Comments

@WangJialei-A
Copy link
Contributor

Developers may synchronize the main branch with the PR branch by merging the main branch into the PR branch. This process might generate a commit that includes modifications to the llvm-version.txt file, which in turn could trigger the LLVM build CI.

Perhaps a better approach would be to hook the llvm-version.txt file only on the main branch.

@WangJialei-A WangJialei-A added enhancement New feature or request ci Continuous integration and automation labels Aug 15, 2024
@leshikus
Copy link
Contributor

There is a problem regarding it, the developer wants their branch to work. If they changed the hash, llvm build has to be made to enable their branch to work.
There is a problem though. The developer has to restart CI on his branch manually once llvm build is completed

@WangJialei-A
Copy link
Contributor Author

There is a problem regarding it, the developer wants their branch to work. If they changed the hash, llvm build has to be made to enable their branch to work. There is a problem though. The developer has to restart CI on his branch manually once llvm build is completed

I think a better practice is to use a separate PR for updating the LLVM version, rather than mixing it with other development work.

If someone updates the LLVM version on the main branch, I believe it is completely acceptable for the CI results of a PR to fail. This failure serves as a reminder to developers that the LLVM version used in their PR is outdated.

@leshikus
Copy link
Contributor

leshikus commented Sep 3, 2024

@WangJialei-A I agree

@lmontigny lmontigny added this to the 0.3 CI/CD milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration and automation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants