Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert mismatch utility into a standalone entity #4300

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

inosmeet
Copy link
Contributor

@inosmeet inosmeet commented Aug 4, 2024

  • mismatch -> this command will run the loader and load the default database with default data.
  • mismatch loader [--dir] [--database] -> same as previous but with ability to define custom data directory and database file.
  • mismatch lookup PURL [--database] -> takes PURL as an argument and returns vendor names associated from database and error if nothing is found.

default values for --dir and --database is tailored for cve-bin-tool, but I think if we were to make it truly standalone, we should make those flags compulsory.

cc @terriko

@inosmeet inosmeet marked this pull request as ready for review August 7, 2024 04:23
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like exactly what we need, but I'd rather not add a new dependency (click) unless we absolutely have to, both for security reasons and because going through our legal licensing compliance for a new dependency adds a lot of time and overhead.

Can you convert this to just use argparse instead?

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll open an issue reminding you to get docs and tests for this done in a separate PR.

@terriko terriko merged commit d2fa085 into intel:main Aug 8, 2024
21 of 22 checks passed
@inosmeet inosmeet deleted the standalone branch August 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants