-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added test for generate_sbom function #4060
Conversation
Signed-off-by: Meet Soni <[email protected]>
Signed-off-by: Meet Soni <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
+ Coverage 75.41% 80.52% +5.10%
==========================================
Files 808 822 +14
Lines 11983 12721 +738
Branches 1598 1983 +385
==========================================
+ Hits 9037 10243 +1206
+ Misses 2593 2050 -543
- Partials 353 428 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @terriko, can you take a look? I've tried to test the if statement along with some other things. |
@inosmeet oh, I assumed since it was still marked as a draft that it didn't need review yet. heading into a meeting right now but I'll try to take a look later this afternoon. |
I forgot to change it to open after I resolved the errors. |
Just a reminder @terriko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay on this one! Looks like we're ready to merge.
Closes: #3997.