Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added test for generate_sbom function #4060

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

inosmeet
Copy link
Contributor

Closes: #3997.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (d6cbe40) to head (87d9203).
Report is 179 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4060      +/-   ##
==========================================
+ Coverage   75.41%   80.52%   +5.10%     
==========================================
  Files         808      822      +14     
  Lines       11983    12721     +738     
  Branches     1598     1983     +385     
==========================================
+ Hits         9037    10243    +1206     
+ Misses       2593     2050     -543     
- Partials      353      428      +75     
Flag Coverage Δ
longtests 75.79% <100.00%> (+0.38%) ⬆️
win-longtests 78.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inosmeet
Copy link
Contributor Author

Hey @terriko, can you take a look? I've tried to test the if statement along with some other things.

@terriko
Copy link
Contributor

terriko commented Apr 25, 2024

@inosmeet oh, I assumed since it was still marked as a draft that it didn't need review yet. heading into a meeting right now but I'll try to take a look later this afternoon.

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Apr 25, 2024
@inosmeet inosmeet marked this pull request as ready for review April 28, 2024 14:15
@inosmeet
Copy link
Contributor Author

I forgot to change it to open after I resolved the errors.

@inosmeet
Copy link
Contributor Author

Just a reminder @terriko

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay on this one! Looks like we're ready to merge.

@terriko terriko merged commit c30c7b7 into intel:main May 30, 2024
22 checks passed
@inosmeet inosmeet deleted the #3997 branch May 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: fix to prevent unknown vendor overwrite
3 participants