Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor insert queries #3145

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: refactor insert queries #3145

merged 1 commit into from
Jul 12, 2023

Conversation

Rexbeast2
Copy link
Contributor

fixes: #3144 @terriko I already had done work for this one and was asking if to include it in that PR or create a separate issue for this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #3145 (56f08df) into main (59e522a) will increase coverage by 0.93%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
+ Coverage   81.35%   82.28%   +0.93%     
==========================================
  Files         716      716              
  Lines       11051    11082      +31     
  Branches     1482     1488       +6     
==========================================
+ Hits         8990     9119     +129     
+ Misses       1661     1581      -80     
+ Partials      400      382      -18     
Flag Coverage Δ
longtests 81.65% <97.77%> (+5.63%) ⬆️
win-longtests 79.34% <97.77%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 67.91% <96.77%> (+3.94%) ⬆️
test/test_cvedb.py 93.75% <100.00%> (+1.75%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the weird design choices we'd made earlier. I think this will be easier for people to read and understand going forwards. Especially since it sounds like we're poised to look at a lot more metrics than we used to!

@terriko terriko merged commit 58a10fd into intel:main Jul 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: replace insert_queries() function in cvedb
3 participants