Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: crash during triage output #4438

Closed
terriko opened this issue Sep 13, 2024 · 1 comment · Fixed by #4440
Closed

bug: crash during triage output #4438

terriko opened this issue Sep 13, 2024 · 1 comment · Fixed by #4440

Comments

@terriko
Copy link
Contributor

terriko commented Sep 13, 2024

From #4417

this test version 3.4rc2 outputs the reports but crashes before making the triage-output file.

This might be related to the comment vs comments problem before -- we may be writing to the wrong field. I'd like this fixed for the 3.4 release.

@tzirn
Copy link

tzirn commented Sep 19, 2024

v3.4 doesn't crash anymore when the command is correct. however when I accidentally didnt put the extension on the end of the --vest-output parameter it did crash
so using:
--vex-output triage0919.json works
--vex-output triage0191 crashes with a stack dump and then "TypeError: cannot unpack non-iterable NoneType object"
not sure that really matters but perhaps a more graceful exit with an error that states to please specify the file extension would be better if it's easy.
Thanks for doing so much work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants