Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove skip-ias-remnants from CI and readme #183

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 3 additions & 71 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:

- uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.os }}-${{ env.RUST_BIN_DIR }}-${{ matrix.binary }}-with-ias
key: ${{ matrix.os }}-${{ env.RUST_BIN_DIR }}-${{ matrix.binary }}

- name: Release
if: ${{ matrix.binary == 'release' }}
Expand All @@ -163,64 +163,6 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

build_dev_ias_binaries:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the same as the regular build_dev_ias_binaries

name: Development build ${{ matrix.binary }} for ${{ matrix.rust-target }} on (${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04]
rust: [stable]
binary: [release]
env:
RUST_BACKTRACE: full
RUSTV: ${{ matrix.rust }}
TARGET: ${{ matrix.rust-target }}
RUST_BIN_DIR: target/${{ matrix.rust-target }}/debug
RELEASE_NAME: debug
steps:
- uses: actions/checkout@v3

- name: Print env
run: |
echo "RUST_BIN_DIR = ${{ env.RUST_BIN_DIR }} "

# With rustup's nice new toml format, we just need to run rustup show to install the toolchain
# https://github.com/actions-rs/toolchain/issues/126#issuecomment-782989659
- name: Setup Rust toolchain
run: rustup show

- name: Install dependencies
run: |
sudo apt update && \
sudo apt install --assume-yes protobuf-compiler

- name: Install llvm-10
run: sudo apt-get install llvm-10 clang-10

- uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.os }}-${{ env.RUST_BIN_DIR }}-${{ matrix.binary }}-with-ias

- name: Release
if: ${{ matrix.binary == 'release' }}
run: cargo build --release --locked --features skip-extrinsic-filtering

# Upload artifacts
- name: Upload integritee-node-dev-ias
uses: actions/upload-artifact@v3
with:
name: integritee-node-dev-ias-${{ github.sha }}
path: target/release/integritee-node

- name: Slack Notification
uses: 8398a7/action-slack@v3
if: failure()
with:
status: ${{ job.status }}
fields: repo,message,commit,author,action,eventName,ref,workflow,job,took # selectable (default: repo,message)
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

build_benchmark_binaries:
name: Benchmarking build ${{ matrix.binary }} for ${{ matrix.rust-target }} on (${{ matrix.os }})
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -257,7 +199,7 @@ jobs:

- uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.os }}-${{ env.RUST_BIN_DIR }}-${{ matrix.binary }}-with-ias
key: ${{ matrix.os }}-${{ env.RUST_BIN_DIR }}-${{ matrix.binary }}

- name: Build benchmarking binary
if: ${{ matrix.binary == 'release' }}
Expand Down Expand Up @@ -486,7 +428,7 @@ jobs:
name: Draft Release
if: startsWith(github.ref, 'refs/tags/')
runs-on: ubuntu-latest
needs: [create_artifacts, build_live_binaries, build_dev_binaries, build_dev_ias_binaries, check]
needs: [create_artifacts, build_live_binaries, build_dev_binaries, check]
outputs:
release_url: ${{ steps.create-release.outputs.html_url }}
asset_upload_url: ${{ steps.create-release.outputs.upload_url }}
Expand All @@ -499,12 +441,6 @@ jobs:
name: integritee-node-dev-${{ github.sha }}
path: integritee-node-dev-tmp

- name: Download Integritee Collator
uses: actions/download-artifact@v3
with:
name: integritee-node-dev-ias-${{ github.sha }}
path: integritee-node-dev-ias-tmp

- name: Download Integritee Collator
uses: actions/download-artifact@v3
with:
Expand All @@ -513,9 +449,6 @@ jobs:
- name: Move binaries
run: mv integritee-node-dev-tmp/integritee-node ./integritee-node-dev

- name: Move binaries
run: mv integritee-node-dev-ias-tmp/integritee-node ./integritee-node-dev-ias

- name: Create required package.json
run: test -f package.json || echo '{}' >package.json

Expand All @@ -539,7 +472,6 @@ jobs:
files: |
integritee-node
integritee-node-dev
integritee-node-dev-ias

- name: Slack Notification
uses: 8398a7/action-slack@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/delete-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
binary: ["integritee-node", "integritee-node-dev", "integritee-node-dev-ias" ]
binary: ["integritee-node", "integritee-node-dev" ]
steps:
- uses: actions/checkout@v3

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-docker-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
binary: ["integritee-node", "integritee-node-dev", "integritee-node-dev-ias"]
binary: ["integritee-node", "integritee-node-dev"]
steps:
- uses: actions/checkout@v3

Expand Down
12 changes: 3 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,13 @@ A substrate-based node that maintains a registry of remote attested integritee-s
## Build and Run
1. See the substrate install docs to install the preliminaries: [https://docs.substrate.io/install](https://docs.substrate.io/install).
2. Build the node:
- If you can perform Remote Attestation:
```
cargo build --release --features "skip-extrinsic-filtering"
```
- If you can **NOT** perform Remote Attestation:
```
cargo build --release --features "skip-extrinsic-filtering skip-ias-check"
```
```
cargo build --release --features "skip-extrinsic-filtering"
```

### Note
There are some cargo features that are highly relevant for developers:

* `skip-ias-check`: allow registering enclaves without attestation report.
* `skip-extrinsic-filtering`: We have a defensive filter for transfer extrinsics as we have an old solo-node running for archive purposes, which mustn't allow transfers. The filter can be deactivated with this feature.

## Versioning
Expand Down
Loading