Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in SDK Docs for SDK business logic implementation #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coax1d
Copy link

@coax1d coax1d commented Mar 13, 2023

No description provided.

@coax1d coax1d self-assigned this Mar 13, 2023
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM, I think the hashmarks could be removed if you agree as well.

@@ -5,7 +5,7 @@
1. Experiment with the template, running the [sidechain demo](../4.6-demos/4.6.1-sidechain-demo.md)​.
2. Fork the worker repository `https://github.com/integritee-network/worker.git` from the SDK release branch (`sdk-v0.10.0-polkadot-v0.9.27`).
3. Build the worker in [sidechain mode](4.4.1-sidechain-sdk.md#building-the-worker-in-sidechain-validateer-mode-a-hrefbuild-sidechain-mode-idbuild-sidechain-modea).
4. Write and integrate your own [#business-logic-stf](4.4.1-sidechain-sdk.md#business-logic-stf "mention"), e.g. in a substrate pallet.
4. Write and integrate your own [#business-logic-stf](4.4.4-custom-business-logic-stf/), e.g. in a substrate pallet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that the hashmark had been there previously nevertheless could you please remove it?

@@ -30,7 +30,7 @@ docker build -t integritee-worker --target deployed-worker --build-arg WORKER_MO

#### **Business logic / STF**

This is the core part of the code changes necessary to turn the generic worker into your specific use-case. Read more in [#business-logic-stf](4.4.1-sidechain-sdk.md#business-logic-stf "mention").
This is the core part of the code changes necessary to turn the generic worker into your specific use-case. Read more in [#business-logic-stf](4.4.4-custom-business-logic-stf/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants