New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool doesn't work if json is indented with tabs. #30

Open

klmz opened this issue Jan 22, 2020 · 0 comments

klmz commented Jan 22, 2020

I was trying to use your tool, and ran into some issues. My problem was with this line:

openapi2jsonschema/openapi2jsonschema/command.py

Lines 66 to 68 in 1ca501f

    
           # Note that JSON is valid YAML, so we can use the YAML parser whether 
        
           # the schema is stored in JSON or YAML 
        
           data = yaml.load(response.read(), Loader=yaml.SafeLoader)

This is only true if the JSON is indented with spaces instead of tabs.

I would propose to just convert indentation to spaces before using the yaml parser. Agreed?

klmz mentioned this issue

Use separate json loader to be able to deal with jsons that use tabs for indenting #31

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment