OutputManager handles error output #333
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects output inconsistencies when errors are found before the configuration hits the schema validator. See: #332
If one specifies the output type of json
-o json
and the config is missing 'apiversion' or 'kind' fields, the error output takes the form of a standard string.Error handling currently bypasses the OutputManager and dumps errors to stdout as regular strings. This update redirects error output to OutputManager. Kubeval still fails fast when a config is loaded that is missing the necessary fields.
Example of config output with and without changes:
Current output:
With updates: