Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the warn for unknown parameters in message.rb #152

Open
cvoege opened this issue Jul 2, 2018 · 1 comment
Open

Remove the warn for unknown parameters in message.rb #152

cvoege opened this issue Jul 2, 2018 · 1 comment

Comments

@cvoege
Copy link

cvoege commented Jul 2, 2018

The warn on line 124 of /models/messages/message.rb means that any time you create a message with standard LTI parameters (user_id, lis_person_contact_email_primary) it will flood your logs with warnings because they are not in the whitelist. Can we either add all the standard LTI parameters into the whitelist or just remove the warn line?

Ideally there would be an option like "error_on_unknown_paramter" which would make it so it would throw an error in an known paramter, otherwise it just continues.

@LucasPiffer
Copy link
Contributor

Awesome, does not make any sense to warn for fields that are expected by the doc https://www.imsglobal.org/specs/ltiv1p1/implementation-guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants