From 83b1313d7be5d4882f41b67c6b9f06d15200f745 Mon Sep 17 00:00:00 2001 From: Greg Sanders Date: Thu, 27 Jun 2024 14:45:01 -0400 Subject: [PATCH] test: Add anchor mempool acceptance test --- test/functional/mempool_accept.py | 51 +++++++++++++++++++ test/functional/test_framework/script_util.py | 3 ++ 2 files changed, 54 insertions(+) diff --git a/test/functional/mempool_accept.py b/test/functional/mempool_accept.py index 2b841f3791e4dc..5cf0ad435f04ef 100755 --- a/test/functional/mempool_accept.py +++ b/test/functional/mempool_accept.py @@ -37,6 +37,7 @@ keys_to_multisig_script, MIN_PADDING, MIN_STANDARD_TX_NONWITNESS_SIZE, + PAY_TO_ANCHOR, script_to_p2sh_script, script_to_p2wsh_script, ) @@ -389,6 +390,56 @@ def run_test(self): maxfeerate=0, ) + self.log.info('OP_1 <0x4e73> is able to be created and spent') + true_tx = self.wallet.create_self_transfer(sequence=SEQUENCE_FINAL)['tx'] + true_tx.vout[0].scriptPubKey = bytes(PAY_TO_ANCHOR) + true_tx.rehash() + self.generateblock(node, self.wallet.get_address(), [true_tx.serialize().hex()]) + + # First spend has non-empty witness, will be rejected to prevent third party wtxid malleability + true_tx_spend = CTransaction() + true_tx_spend.vin.append(CTxIn(COutPoint(true_tx.sha256, 0), b"")) + true_tx_spend.vout.append(CTxOut(true_tx.vout[0].nValue - int(fee*COIN), script_to_p2wsh_script(CScript([OP_TRUE])))) + true_tx_spend.wit.vtxinwit.append(CTxInWitness()) + true_tx_spend.wit.vtxinwit[0].scriptWitness.stack.append(b"f") + true_tx_spend.rehash() + + self.check_mempool_result( + result_expected=[{'txid': true_tx_spend.rehash(), 'allowed': False, 'reject-reason': 'bad-witness-nonstandard'}], + rawtxs=[true_tx_spend.serialize().hex()], + maxfeerate=0, + ) + + # Clear witness stuffing + true_tx_spend.wit.vtxinwit[0].scriptWitness.stack = [] + true_tx_spend.rehash() + + self.check_mempool_result( + result_expected=[{'txid': true_tx_spend.rehash(), 'allowed': True, 'vsize': true_tx_spend.get_vsize(), 'fees': { 'base': Decimal('0.00000700')}}], + rawtxs=[true_tx_spend.serialize().hex()], + maxfeerate=0, + ) + + self.log.info('But cannot be spent if nested sh()') + nested_true_tx = self.wallet.create_self_transfer(sequence=SEQUENCE_FINAL)['tx'] + nested_true_tx.vout[0].scriptPubKey = script_to_p2sh_script(PAY_TO_ANCHOR) + nested_true_tx.rehash() + self.generateblock(node, self.wallet.get_address(), [nested_true_tx.serialize().hex()]) + + nested_true_tx_spend = CTransaction() + nested_true_tx_spend.vin.append(CTxIn(COutPoint(nested_true_tx.sha256, 0), b"")) + nested_true_tx_spend.vin[0].scriptSig = CScript([bytes(PAY_TO_ANCHOR)]) + nested_true_tx_spend.vout.append(CTxOut(true_tx.vout[0].nValue - int(fee*COIN), script_to_p2wsh_script(CScript([OP_TRUE])))) + nested_true_tx_spend.rehash() + + self.check_mempool_result( + result_expected=[{'txid': nested_true_tx_spend.rehash(), 'allowed': False, 'reject-reason': 'non-mandatory-script-verify-flag (Witness version reserved for soft-fork upgrades)'}], + rawtxs=[nested_true_tx_spend.serialize().hex()], + maxfeerate=0, + ) + # but is consensus-legal + self.generateblock(node, self.wallet.get_address(), [nested_true_tx_spend.serialize().hex()]) + self.log.info('Spending a confirmed bare multisig is okay') address = self.wallet.get_address() tx = tx_from_hex(raw_tx_reference) diff --git a/test/functional/test_framework/script_util.py b/test/functional/test_framework/script_util.py index 855f3b8cf59bb8..938183ece4c5f2 100755 --- a/test/functional/test_framework/script_util.py +++ b/test/functional/test_framework/script_util.py @@ -8,6 +8,7 @@ from test_framework.script import ( CScript, OP_0, + OP_1, OP_15, OP_16, OP_CHECKMULTISIG, @@ -42,6 +43,8 @@ DUMMY_MIN_OP_RETURN_SCRIPT = CScript([OP_RETURN] + ([OP_0] * (MIN_PADDING - 1))) assert len(DUMMY_MIN_OP_RETURN_SCRIPT) == MIN_PADDING +PAY_TO_ANCHOR = CScript([OP_1, bytes.fromhex("4e73")]) + def key_to_p2pk_script(key): key = check_key(key) return CScript([key, OP_CHECKSIG])