Deprecation warning with Rails 7.1

[jwoodrow]

I managed to get makara working (at least it seems to be working so far) but I've got a pesky warning

DEPRECATION WARNING: new is deprecated and will be removed from Rails 7.2 (use ActiveRecord::ConnectionAdapters::SchemaReflection instead)

caused by this line lib/active_record/connection_adapters/makara_abstract_adapter.rb:193

I have no real idea how the makara magic works but I noticed there wasn't an issue opened with this problem, thanks for the hard work 🙏

Also out of curiosity, I can't seem to get automatic failover to master working in a specific case, I want to failover on ActiveRecord::RecordNotFound exception to take into account replication lag in jobs (I configured my jobs to not stick to primary so I could prioritize using the replica database as much as possible until they do a write but some jobs are enqueued right after a create to the database and for those I would like to be able to fallback to the primary database)

[jwoodrow]

Did some blind digging and testing to try and remove the warning, this seems to work in place of the deprecated call

schema_reflection = ActiveRecord::ConnectionAdapters::SchemaReflection.new(nil).load!(@proxy)
@schema_cache = ActiveRecord::ConnectionAdapters::BoundSchemaReflection.new(schema_reflection, @proxy)

Wouldn't mind if someone more knowledgable could confirm if this is sufficient or not 🤔