Refactoring android tests to use utils/android (pt3). #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Sep 19, 2024
| initFormula = { app -> | ||
| FormulaAndroid.init(app) { | ||
| private fun runTest(continuation: (FormulaAndroidInteractor) -> Unit) { | ||
| withFormulaAndroid( |
There was a problem hiding this comment.
Refactoring the test to use withFormulaAndroid instead of TestFormulaRule
JaCoCo Code Coverage 97.11% ✅
Generated by 🚫 Danger |
Laimiux
commented
Sep 19, 2024
| @@ -0,0 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
Laimiux
force-pushed
the
laimonas/refactoring-android-tests-pt3
branch
from
e499566
to
ad7e65d
Compare
Laimiux
force-pushed
the
laimonas/refactoring-android-tests-pt3
branch
from
ad7e65d
to
da87d2a
Compare
alexanderbezverhni
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to start moving tests from
formula-android-testsintoformula-androidmodule and keep test utilities withintest-utils/androidmodule.