Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property TrueTimeClient.started is needed #110

Open
AlexMokrushin opened this issue Nov 27, 2023 · 1 comment
Open

Property TrueTimeClient.started is needed #110

AlexMokrushin opened this issue Nov 27, 2023 · 1 comment

Comments

@AlexMokrushin
Copy link

Hello.
I'm starting TrueTimeClient inside my custom library. One my client is using my library and also using (and starting) TrueTimeClient. As result app crashes on precondition check with message "Already started".
I need to add option to check and NOT to start shared TrueTimeClient if it is already started to avoid the crash. Almost the same issue was here #18, but it was closed with comment, not really fixed.
As I can see, NTPClient already has "started"-property, but it is inaccessible in TrueTimeClient cause its ntp member marked as private.
It would be great to make TrueTimeClient.started available.
Thanks!
@AlexMokrushin
Copy link
Author

I have prepared Pull Request for this issue: #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexMokrushin