Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you release a version? #406

Open
AllenX2018 opened this issue Dec 30, 2020 · 5 comments
Open

can you release a version? #406

AllenX2018 opened this issue Dec 30, 2020 · 5 comments

Comments

@AllenX2018
Copy link

Hello ~ community maintainer:
the community has not released a version for a long time, can you release a version?

@insomniacslk
Copy link
Owner

CC @pmazzini @hugelgupf @Natolumin . Anything missing before we cut a release? Even better if 1.x ?

@pmazzini
Copy link
Collaborator

Chris wanted to remove the async client before the 1.x release: #400 (comment)

His pinterest/bender PR was never merged though: pinterest/bender#39

I am ok with cutting a release. If we can remove the async client even better.

@Natolumin
Copy link
Collaborator

There isn't anything specifically missing for v1 that I can think of, but anyway if it's just adding missing things we can do it within a minor release

Releasing a v1 means we have to actually be careful about breaking api changes from now on (which I'm definitely happy about), so maybe we want to make a pass at unexporting things we don't want to guarantee stability on, or that aren't directly useful to clients ?
There are a couple APIs that have shown to cause issues (most notably ToBytes not being able to error out, but I'm sure there are others I forgot about); on that point I'd say releasing a v1 would be a positive so we can knowingly select things to break with an eventual v2 as well

@hugelgupf
Copy link
Collaborator

Let's get it out the door and remove / change things in v2... only have so much time rn

@s3rj1k
Copy link

s3rj1k commented Jul 30, 2023

Release never happened, maybe a 0.x release at least?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants